Use vec_expand_grid()
#1470
Merged
Use vec_expand_grid()
#1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
feature/vec-expand-grid
branch
from
c7ddd14 to
f07615f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can wait to merge until after vctrs is on CRAN.
vec_expand_grid()doesn't splice unnamed data frames. It requires all inputs to be named. So this requires a little tweaking to account for that.I really don't know if splicing unnamed data frames is a particularly useful feature, so I tried to be more conservative in
vec_expand_grid()and didn't allow that for now. I think it makes thevec_expand_grid()implementation simpler since this is a feature I don't feel particularly strongly about.