New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts within the tidyverse are not consistently called out #26

Closed
jennybc opened this Issue Nov 29, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@jennybc
Member

jennybc commented Nov 29, 2016

I am specifically thinking of jsonlite::flatten().

tidyverse then jsonlite: we're notified that jsonlite::flatten() masks purrr::flatten(). But not reported as a conflict.

library(tidyverse)
#> Loading tidyverse: ggplot2
#> Loading tidyverse: tibble
#> Loading tidyverse: tidyr
#> Loading tidyverse: readr
#> Loading tidyverse: purrr
#> Loading tidyverse: dplyr
#> Conflicts with tidy packages ----------------------------------------------
#> filter(): dplyr, stats
#> lag():    dplyr, stats
library(jsonlite)
#> 
#> Attaching package: 'jsonlite'
#> The following object is masked from 'package:purrr':
#> 
#>     flatten
tidyverse_conflicts()
#> Conflicts with tidy packages ----------------------------------------------
#> filter(): dplyr, stats
#> lag():    dplyr, stats

jsonlite then tidyverse: we don't learn that purrr::flatten() masks jsonlite::flatten(). Still not reported as a conflict.

library(jsonlite)
library(tidyverse)
#> Loading tidyverse: ggplot2
#> Loading tidyverse: tibble
#> Loading tidyverse: tidyr
#> Loading tidyverse: readr
#> Loading tidyverse: purrr
#> Loading tidyverse: dplyr
#> Conflicts with tidy packages ----------------------------------------------
#> filter(): dplyr, stats
#> lag():    dplyr, stats
tidyverse_conflicts()
#> Conflicts with tidy packages ----------------------------------------------
#> filter(): dplyr, stats
#> lag():    dplyr, stats

jsonlite then purrr: we learn that purrr::flatten() masks jsonlite::flatten().

library(jsonlite)
library(purrr)
#> 
#> Attaching package: 'purrr'
#> The following object is masked from 'package:jsonlite':
#> 
#>     flatten
@hadley

This comment has been minimized.

Member

hadley commented Dec 29, 2016

Oooooooh, that's because jsonlite is a tidyverse package, so the conflict is deliberately excluded.

@jennybc

This comment has been minimized.

Member

jennybc commented Feb 25, 2017

Also contains() from dplyr and purrr.

@sebastian-c

This comment has been minimized.

sebastian-c commented Mar 28, 2017

The contains issue has been dealt with at least (tidyverse/purrr#217)

@jennybc

This comment has been minimized.

Member

jennybc commented Apr 19, 2017

Also extract() from tidyr and purrr

@jennybc

This comment has been minimized.

Member

jennybc commented Oct 26, 2017

collapse() from dplyr and glue

@hadley hadley closed this in f03fd56 Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment