Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated package name #100

Merged
merged 2 commits into from Jan 25, 2018
Merged

Fix repeated package name #100

merged 2 commits into from Jan 25, 2018

Conversation

@dchiu911
Copy link
Contributor

@dchiu911 dchiu911 commented Dec 12, 2017

  • Fixes bug reported in #94 regarding odd number of packages to attach
@dchiu911 dchiu911 changed the title Fixes #94 Fix repeated package name Dec 12, 2017
@jennybc
Copy link
Member

@jennybc jennybc commented Jan 24, 2018

I think this is a bit cleaner. Will you change in your branch?

if (length(packages) %% 2 == 1) {
    packages <- append(packages, "")
  }
col1 <- seq_len(length(packages)/2)
info <- paste0(packages[col1], "     ", packages[-col1])
@jennybc
Copy link
Member

@jennybc jennybc commented Jan 25, 2018

Thanks!

@jennybc jennybc merged commit 2b5330e into tidyverse:master Jan 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dchiu911 dchiu911 deleted the dchiu911:fix-attach branch Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants