Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add repos option to tidyverse_{deps,update} #82

Merged
merged 5 commits into from May 10, 2019

Conversation

@zkamvar
Copy link
Contributor

commented Nov 8, 2017

This allows users who accidentally have repos set to "@CRAN@" to be able to quickly specify a repository by calling back the last command and adding repos = "<valid_cran_repo>".

Yes, the same thing can be achieved by having the user type options(repos = "<valid_cran_repo>") and then re-running the tidyverse command, but muscle memory is a difficult habit to shake.

add repos option to tidyverse_{deps,update}
This allows users who accidentally have repos set
to "@cran@" to be able to quickly specify a
repository by calling back the last command and
adding repos = "<valid_cran_repo>".

Yes, the same thing can be achieved by having the
user type options(repos = "<valid_cran_repo>") and
then re-running the tidyverse command, but muscle
memory is a difficult habit to shake.
@hadley

This comment has been minimized.

Copy link
Member

commented Apr 26, 2018

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

@zkamvar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2018

Done. Feel free to modify if it's too terse.

@codecov

This comment has been minimized.

Copy link

commented Apr 29, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@b871a39). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #82   +/-   ##
=========================================
  Coverage          ?   59.17%           
=========================================
  Files             ?        7           
  Lines             ?      169           
  Branches          ?        0           
=========================================
  Hits              ?      100           
  Misses            ?       69           
  Partials          ?        0
Impacted Files Coverage Δ
R/update.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b871a39...fd6020e. Read the comment docs.

@hadley hadley merged commit 264273d into tidyverse:master May 10, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hadley

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Thanks!

@zkamvar zkamvar deleted the zkamvar:add-repo-arg branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.