Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add refit.model_mean #289

Merged
merged 5 commits into from Jul 1, 2020
Merged

add refit.model_mean #289

merged 5 commits into from Jul 1, 2020

Conversation

Tim-TU
Copy link
Contributor

@Tim-TU Tim-TU commented Jul 1, 2020

Added another refit method for the MEAN model listed in #284

mitchelloharawild
mitchelloharawild requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@mitchelloharawild mitchelloharawild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Only a few minor changes needed:

Could you:

  1. Add an improvement to the NEWS (much like f7ec892)
  2. Add refit.model_mean to the pkgdown reference (much like ff8759b)

R/mean.R Outdated Show resolved Hide resolved
mitchelloharawild
mitchelloharawild approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@mitchelloharawild mitchelloharawild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks heaps!

@mitchelloharawild mitchelloharawild merged commit 3d7346a into tidyverts:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelloharawild mitchelloharawild mitchelloharawild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tim-TU @mitchelloharawild