fill_gaps with .full=start() or end() fails

[hongooi73]

From the example on the pkgdown page:

harvest <- tsibble(
  year = c(2010, 2011, 2013, 2011, 2012, 2014),
  fruit = rep(c("kiwi", "cherry"), each = 3),
  kilo = sample(1:10, size = 6),
  key = fruit, index = year
)

fill_gaps(harvest, .full = start())

Error in hasTsp(x) : argument "x" is missing, with no default

This is with tsibble 0.8.6. Here's the full sessionInfo():

R version 3.6.2 (2019-12-12)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.4 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.7.1
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.7.1

locale:
 [1] LC_CTYPE=C.UTF-8       LC_NUMERIC=C           LC_TIME=C.UTF-8       
 [4] LC_COLLATE=C.UTF-8     LC_MONETARY=C.UTF-8    LC_MESSAGES=C.UTF-8   
 [7] LC_PAPER=C.UTF-8       LC_NAME=C              LC_ADDRESS=C          
[10] LC_TELEPHONE=C         LC_MEASUREMENT=C.UTF-8 LC_IDENTIFICATION=C   

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] fable_0.1.2      feasts_0.1.2     fabletools_0.1.2 tsibble_0.8.6   
[5] dplyr_0.8.4      tidyr_1.0.2     

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.3       pillar_1.4.3     compiler_3.6.2   tools_3.6.2     
 [5] lubridate_1.7.4  lifecycle_0.1.0  tibble_2.1.3     gtable_0.3.0    
 [9] anytime_0.3.7    pkgconfig_2.0.3  rlang_0.4.4      cli_2.0.1       
[13] yaml_2.2.1       stringr_1.4.0    generics_0.0.2   vctrs_0.2.2     
[17] rprojroot_1.3-2  grid_3.6.2       tidyselect_1.0.0 glue_1.3.1      
[21] here_0.1         R6_2.4.1         fansi_0.4.1      ggplot2_3.2.1   
[25] purrr_0.3.3      magrittr_1.5     ellipsis_0.3.0   scales_1.1.0    
[29] backports_1.1.5  assertthat_0.2.1 colorspace_1.4-1 utf8_1.1.4      
[33] stringi_1.4.6    lazyeval_0.2.2   munsell_0.5.0    crayon_1.3.4 

[earowang]

I can’t reproduce the example locally. Can you run the example on a fresh R session? That is not attaching fable and feasts. Cheers, Earo

…

On 18 Mar 2020, at 15:09, Hong Ooi wrote: From the example on the [pkgdown page](https://tsibble.tidyverts.org/reference/fill_gaps.html): ```r harvest <- tsibble( year = c(2010, 2011, 2013, 2011, 2012, 2014), fruit = rep(c("kiwi", "cherry"), each = 3), kilo = sample(1:10, size = 6), key = fruit, index = year ) fill_gaps(harvest, .full = start()) ``` ``` Error in hasTsp(x) : argument "x" is missing, with no default ``` This is with tsibble 0.8.6. Here's the full `sessionInfo()`: ``` R version 3.6.2 (2019-12-12) Platform: x86_64-pc-linux-gnu (64-bit) Running under: Ubuntu 18.04.4 LTS Matrix products: default BLAS: /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.7.1 LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.7.1 locale: [1] LC_CTYPE=C.UTF-8 LC_NUMERIC=C LC_TIME=C.UTF-8 [4] LC_COLLATE=C.UTF-8 LC_MONETARY=C.UTF-8 LC_MESSAGES=C.UTF-8 [7] LC_PAPER=C.UTF-8 LC_NAME=C LC_ADDRESS=C [10] LC_TELEPHONE=C LC_MEASUREMENT=C.UTF-8 LC_IDENTIFICATION=C attached base packages: [1] stats graphics grDevices utils datasets methods base other attached packages: [1] fable_0.1.2 feasts_0.1.2 fabletools_0.1.2 tsibble_0.8.6 [5] dplyr_0.8.4 tidyr_1.0.2 loaded via a namespace (and not attached): [1] Rcpp_1.0.3 pillar_1.4.3 compiler_3.6.2 tools_3.6.2 [5] lubridate_1.7.4 lifecycle_0.1.0 tibble_2.1.3 gtable_0.3.0 [9] anytime_0.3.7 pkgconfig_2.0.3 rlang_0.4.4 cli_2.0.1 [13] yaml_2.2.1 stringr_1.4.0 generics_0.0.2 vctrs_0.2.2 [17] rprojroot_1.3-2 grid_3.6.2 tidyselect_1.0.0 glue_1.3.1 [21] here_0.1 R6_2.4.1 fansi_0.4.1 ggplot2_3.2.1 [25] purrr_0.3.3 magrittr_1.5 ellipsis_0.3.0 scales_1.1.0 [29] backports_1.1.5 assertthat_0.2.1 colorspace_1.4-1 utf8_1.1.4 [33] stringi_1.4.6 lazyeval_0.2.2 munsell_0.5.0 crayon_1.3.4 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #179

[hongooi73]

Yes, I get the same error even with only tsibble attached.

R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> library(tsibble)
> harvest <- tsibble(
  year = c(2010, 2011, 2013, 2011, 2012, 2014),
  fruit = rep(c("kiwi", "cherry"), each = 3),
  kilo = sample(1:10, size = 6),
  key = fruit, index = year
)
fill_gaps(harvest, .full = start())
Error in hasTsp(x) : argument "x" is missing, with no default
> 

[hongooi73]

I do have vctrs 0.2.2 and tibble 2.1.3 installed, if that makes a difference.

[hongooi73]

Ok, it does work with tsibble 0.8.9.9000 on my Windows machine (but the other tidyverts dev packages are very messy right now):

> library(tsibble)
> sessionInfo()
R version 3.6.2 (2019-12-12)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale:
[1] LC_COLLATE=English_Australia.1252  LC_CTYPE=English_Australia.1252   
[3] LC_MONETARY=English_Australia.1252 LC_NUMERIC=C                      
[5] LC_TIME=English_Australia.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] tsibble_0.8.9.9000

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.3          lubridate_1.7.4     crayon_1.3.4       
 [4] dplyr_0.8.5         assertthat_0.2.1    R6_2.4.1           
 [7] lifecycle_0.2.0     magrittr_1.5        pillar_1.4.3       
[10] stringi_1.4.3       rlang_0.4.5         vctrs_0.2.99.9010  
[13] ellipsis_0.3.0      tools_3.6.2         stringr_1.4.0      
[16] glue_1.3.2          purrr_0.3.3         anytime_0.3.7      
[19] compiler_3.6.2      pkgconfig_2.0.3     tidyselect_1.0.0   
[22] tibble_2.99.99.9014
> harvest <- tsibble(
+   year = c(2010, 2011, 2013, 2011, 2012, 2014),
+   fruit = rep(c("kiwi", "cherry"), each = 3),
+   kilo = sample(1:10, size = 6),
+   key = fruit, index = year
+ )
> 
> fill_gaps(harvest, .full = start())
# A tsibble: 9 x 3 [1Y]
# Key:       fruit [2]
   year fruit   kilo
  <dbl> <chr>  <int>
1  2010 cherry    NA
2  2011 cherry     1
3  2012 cherry    10
4  2013 cherry    NA
5  2014 cherry     3
6  2010 kiwi       5
7  2011 kiwi       7
8  2012 kiwi      NA
9  2013 kiwi       8
> 

[earowang]

You probably need to update `tibble` only. Looks like incompatible with tibble earlier versions. Cheers, Earo

…

On 18 Mar 2020, at 15:33, Hong Ooi wrote: Ok, it does work with tsibble 0.8.9.9000 on my Windows machine (but the other tidyverts packages are very messy right now): ``` > library(tsibble) > sessionInfo() R version 3.6.2 (2019-12-12) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 18363) Matrix products: default locale: [1] LC_COLLATE=English_Australia.1252 LC_CTYPE=English_Australia.1252 [3] LC_MONETARY=English_Australia.1252 LC_NUMERIC=C [5] LC_TIME=English_Australia.1252 attached base packages: [1] stats graphics grDevices utils datasets methods base other attached packages: [1] tsibble_0.8.9.9000 loaded via a namespace (and not attached): [1] Rcpp_1.0.3 lubridate_1.7.4 crayon_1.3.4 [4] dplyr_0.8.5 assertthat_0.2.1 R6_2.4.1 [7] lifecycle_0.2.0 magrittr_1.5 pillar_1.4.3 [10] stringi_1.4.3 rlang_0.4.5 vctrs_0.2.99.9010 [13] ellipsis_0.3.0 tools_3.6.2 stringr_1.4.0 [16] glue_1.3.2 purrr_0.3.3 anytime_0.3.7 [19] compiler_3.6.2 pkgconfig_2.0.3 tidyselect_1.0.0 [22] tibble_2.99.99.9014 > harvest <- tsibble( + year = c(2010, 2011, 2013, 2011, 2012, 2014), + fruit = rep(c("kiwi", "cherry"), each = 3), + kilo = sample(1:10, size = 6), + key = fruit, index = year + ) > > fill_gaps(harvest, .full = start()) # A tsibble: 9 x 3 [1Y] # Key: fruit [2] year fruit kilo <dbl> <chr> <int> 1 2010 cherry NA 2 2011 cherry 1 3 2012 cherry 10 4 2013 cherry NA 5 2014 cherry 3 6 2010 kiwi 5 7 2011 kiwi 7 8 2012 kiwi NA 9 2013 kiwi 8 > ``` -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #179 (comment)

[mitchelloharawild]

Other tidyverts dev packages (on master branch) should now be fine with tsibble and tibble CRAN and dev versions.