Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance opt-in changes #1506

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Compliance opt-in changes #1506

merged 2 commits into from
Jun 12, 2024

Conversation

vara2504
Copy link
Contributor

@vara2504 vara2504 commented May 31, 2024

https://tigera.atlassian.net/browse/EV-4834

From 3.20, compliance components will not be deployed by default. User would be enabling compliance feature to get the resources deployed

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@vara2504 vara2504 requested a review from a team as a code owner May 31, 2024 20:29
Copy link

netlify bot commented May 31, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 38beb07
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/6669e1cd421de00008b3ef62
😎 Deploy Preview https://deploy-preview-1506--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 31 (🔴 down 12 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 38beb07
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/6669e1cda95f0b00087c0736
😎 Deploy Preview https://deploy-preview-1506--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30 (🔴 down 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change all references of compliance to a lower case c, for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change all references of compliance to a lower case c, for consistency.

On the Manager UI, click **Compliance Reports**, **Configure Compliance Reports**.

:::note
Enabling packet capture might take a few seconds to create the compliance deployment, daemonset and other dependent resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Enabling compliance ?

On the Manager UI, click **Compliance Reports**, **Configure Compliance Reports**.

:::note
Enabling packet capture might take a few seconds to create the compliance deployment, daemonset and other dependent resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Enabling compliance ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any prerequisites of note we want to highlight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't thing there would be any prerequisites for enabling compliance.
However, there be prerequisites to enable compliance before other configuring compliance features hence made changes for those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any prerequisites of note we want to highlight?

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for you @vara2504. Thanks for this!

Comment on lines 33 to 35
```bash
kubectl get compliance tigera-secure
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the command to verify compliance is enabled in cluster

calico-cloud/compliance/compliance-reports-cis.mdx Outdated Show resolved Hide resolved
description: Enable compliance to configure reports to assess compliance for all assets in a Kubernetes cluster.
---

# Enable Compliance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title doesn't sound quite right to me, but maybe I'm just not familiar with the jargon. "Compliance" sounds like a large, abstract concept. The function of this set of features is to enable reporting that lets you figure out whether your system complies with various standards, right?

If I'm not off here, we should go with a title along the lines of "Enable compliance reporting".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change instances of 'compliance' to 'compliance reporting' throughout, where applicable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compliance include compliance reports, compliance snapshot and compliance benchmark. How able using "compliance features" instead @ctauchen

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that there's a specific component that deals with reports, while others do other things. But I still think the general idea here is all in service of the compliance reports, no?

And in any case, we should continue to match the UI, which is clearly about enabling compliance reports, not 'compliance' or 'compliance features'.

We can open the conversation wider if necessary, but I'm pretty confident we should just change these to 'compliance reports' throughout.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @vara2504


The compliance system consists of several key components that work together to ensure comprehensive compliance monitoring and reporting:

- **compliance-snapshotter:** Lists required configurations and pushes snapshots to Elasticsearch, providing visibility into configuration changes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like component names. Better to have these formatted in code font.

Comment on lines 38 to 40
:::note
Enabling compliance might take a few seconds to create the compliance deployment, daemonset and other dependent resources.
:::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless this is a truly long time, remove this note. It's fair to expect users to understand it's not instant. And I would hope there's some kind of status indicator in the UI.


### Enable Compliance using kubectl

Create a compliance custom resource, named `tigera-secure`, in the cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a procedure has only one step, format as a bulleted list. So:

* Create a compliance ...

Comment on lines 25 to 32
```bash
kubectl apply -f - <<EOF
apiVersion: operator.tigera.io/v1
kind: Compliance
metadata:
name: tigera-secure
EOF
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And don't forget to indent this block to match the instruction.

EOF
```

### Enable Compliance using Manager UI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Enable Compliance using Manager UI
### Enable compliance (reporting?) using Manager UI


## Big picture

Enabling compliance improves the cluster's compliance posture. It involves generating compliance reports for Kubernetes clusters based on archived flow and audit logs for Calico Enterprise and Kubernetes resources. The process includes components for snapshotting configurations, generating reports, managing jobs, providing APIs with RBAC, and benchmarking security.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that first statement is true. Doesn't this just enable reporting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compliance include compliance reports, compliance snapshot and compliance benchmark. How able using "compliance features" instead @ctauchen

Comment on lines 33 to 35
```bash
kubectl get compliance tigera-secure
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove. Users can visit the doc to figure out details about the requirement.

@ctauchen ctauchen added this to the Release | CE 3.20 EP1 milestone Jun 6, 2024
@vara2504
Copy link
Contributor Author

vara2504 commented Jun 7, 2024

@ctauchen Addressed all the review comments

Copy link
Contributor

@dimitri-nicolo dimitri-nicolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctauchen
Copy link
Collaborator

ctauchen commented Jun 7, 2024

@ctauchen Addressed all the review comments

@vara2504 , there's still the changes for complance --> compliance reports. This applies to all titles and other similar usage.

@vara2504 vara2504 force-pushed the comp_optin branch 3 times, most recently from 0ee28d9 to e9fb4cf Compare June 11, 2024 23:44
@rene-dekker rene-dekker merged commit e2630f9 into tigera:main Jun 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants