Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRDs [r1.30] #2648

Merged
merged 1 commit into from May 18, 2023
Merged

Update CRDs [r1.30] #2648

merged 1 commit into from May 18, 2023

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented May 18, 2023

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd requested a review from a team as a code owner May 18, 2023 16:33
@marvin-tigera marvin-tigera added this to the v1.30.0 milestone May 18, 2023
@tmjd tmjd added hold merge Do not merge and removed hold merge Do not merge labels May 18, 2023
rene-dekker
rene-dekker approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmjd tmjd merged commit 211d7e8 into tigera:release-v1.30 May 18, 2023
2 checks passed
@tmjd tmjd deleted the update-crds-v1.30 branch May 18, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene-dekker rene-dekker rene-dekker approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmjd @rene-dekker @marvin-tigera