New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination bug on home page #101

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
2 participants
@MartinPeverelli
Copy link
Contributor

MartinPeverelli commented Apr 26, 2017

Safety check before rtrim() call in order to support pagination on source/index.blade.php

When using pagination on the home page source/index.blade.php, the call to $pagination->previous when on the second page returns null.

I believe the issue lies withing TightenCo\Jigsaw\Collection\ CollectionPaginator:: getPageLink() that performs a return rtrim($this->outputPathResolver->link(...), '/');

Fix pagination bug on home page
Safety check before rtrim() call in order to support pagination on source/index.blade.php

@damiani damiani merged commit f5128fc into tightenco:master Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment