Fix the issue that leader change with new leader info cause invalidStore state and lead to unnecessary backoff #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state and lead to unnecessary backoff Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
@crazycs520 @zyguan @cfzjywxk PTAL |
cfzjywxk
approved these changes
Jan 15, 2024
| @@ -1008,6 +1009,10 @@ func (s *replicaSelector) proxyReplica() *replica { | |||
| return nil | |||
| } | |||
|
|
|||
| func sliceIdentical[T any](a, b []T) bool { | |||
There was a problem hiding this comment.
Better to comment about this function.
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
zyguan
approved these changes
Jan 15, 2024
crazycs520
approved these changes
Jan 15, 2024
13 tasks
13 tasks
This was referenced Jan 23, 2024
MyonKeminta
changed the title
|
@MyonKeminta Could you cherry-pick this PR to tidb-6.5-with-kv-timeout-feature branch? |
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
May 11, 2024
…ore state and lead to unnecessary backoff (tikv#1115) * Fix the issue that leader change with nea leader info cause invalidStore state and lead to unnecessary backoff Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * address comments Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> --------- Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
cfzjywxk
pushed a commit
that referenced
this pull request
May 14, 2024
…ore state and lead to unnecessary backoff (#1115) (#1337) * Fix the issue that leader change with nea leader info cause invalidStore state and lead to unnecessary backoff (#1115) * Fix the issue that leader change with nea leader info cause invalidStore state and lead to unnecessary backoff Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * address comments Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> --------- Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * Fix build on go1.18 Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> --------- Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112