Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPromote @niedhui to committer #44
Merged
Conversation
Signed-off-by: Breezewish <me@breeswish.org>
This comment has been minimized.
This comment has been minimized.
|
Reminder - this requires supermajority votes from TiKV Maintainers. @breeswish |
This comment has been minimized.
This comment has been minimized.
Hoverbear
commented
Dec 27, 2019
|
Yay! Go @niedhui :) You are amazing! |
This comment has been minimized.
This comment has been minimized.
|
Congratulations @niedhui |
This comment has been minimized.
This comment has been minimized.
niedhui
commented
Dec 28, 2019
|
It is such an honor for me and thanks for your help in the past, I'm really looking forward to contributing more to the TiKV project. |
This comment has been minimized.
This comment has been minimized.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
breeswish commentedDec 27, 2019
@niedhui contributed more than 40 PRs in TiKV, mainly for the Coprocessor component: https://github.com/tikv/tikv/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Aniedhui+
Besides implementing a lot of built-in functions, he has also implemented several important TiKV coprocessor features:
Use the new codec for Coprocessor component
Support row format v2
He has revealed great understanding for the Coprocessor module according to these PRs. He has also helped reviewed many community PRs. For this reason, I nominate to promote him as a committer.