Skip to content
GitHub no longer supports this web browser. Learn more about the browsers we support.
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote @niedhui to committer #44

Merged
merged 1 commit into from Dec 30, 2019
Merged

Promote @niedhui to committer #44

merged 1 commit into from Dec 30, 2019

Conversation

@breeswish
Copy link
Member

breeswish commented Dec 27, 2019

@niedhui contributed more than 40 PRs in TiKV, mainly for the Coprocessor component: https://github.com/tikv/tikv/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Aniedhui+

Besides implementing a lot of built-in functions, he has also implemented several important TiKV coprocessor features:

Use the new codec for Coprocessor component

Support row format v2

He has revealed great understanding for the Coprocessor module according to these PRs. He has also helped reviewed many community PRs. For this reason, I nominate to promote him as a committer.

Signed-off-by: Breezewish <me@breeswish.org>
@breeswish breeswish requested a review from tikv/co-community as a code owner Dec 27, 2019
@dcalvin

This comment has been minimized.

Copy link
Member

dcalvin commented Dec 27, 2019

Reminder - this requires supermajority votes from TiKV Maintainers. @breeswish

@Hoverbear

This comment has been minimized.

Copy link

Hoverbear commented Dec 27, 2019

Yay! Go @niedhui :) You are amazing!

@lonng

This comment has been minimized.

Copy link
Member

lonng commented Dec 27, 2019

Congratulations @niedhui

@niedhui

This comment has been minimized.

Copy link

niedhui commented Dec 28, 2019

It is such an honor for me and thanks for your help in the past, I'm really looking forward to contributing more to the TiKV project.

@winkyao

This comment has been minimized.

Copy link
Collaborator

winkyao commented Dec 30, 2019

LGTM

Copy link

BusyJay left a comment

@niedhui Congrats!

@siddontang siddontang merged commit c574d0f into master Dec 30, 2019
1 check passed
1 check passed
DCO All commits are signed off!
Details
@lonng lonng deleted the promote-niedhui branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.