Skip to content

pdctl: escape the key before query the corresponding region#1299

Merged
nolouch merged 3 commits into
tikv:masterfrom
nolouch:escape-key
Oct 29, 2018
Merged

pdctl: escape the key before query the corresponding region#1299
nolouch merged 3 commits into
tikv:masterfrom
nolouch:escape-key

Conversation

@nolouch
Copy link
Copy Markdown
Contributor

@nolouch nolouch commented Oct 26, 2018

What problem does this PR solve?

We should escape the key otherwise will not get the corresponding region.

What is changed and how it works?

escape the key in query URL.

Check List

Tests

  • Unit test

@nolouch nolouch changed the title pd-ctl: escape the key before query the corresponding region pdctl: escape the key before query the corresponding region Oct 26, 2018
@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Oct 26, 2018
@nolouch nolouch merged commit 4cdbcca into tikv:master Oct 29, 2018
@nolouch nolouch deleted the escape-key branch October 29, 2018 03:06
@disksing disksing added the needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. label Nov 7, 2018
disksing pushed a commit to oh-my-tidb/pd that referenced this pull request Nov 8, 2018
disksing added a commit that referenced this pull request Nov 8, 2018
* pdctl: fix region key problems in detach mode (#1298)

* pd-ctl: escape the key before query the corresponding region (#1299)

* pdctl: fix decode key (#1308)

Signed-off-by: disksing <i@disksing.com>
@nolouch nolouch added the needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. label Nov 13, 2018
disksing added a commit to oh-my-tidb/pd that referenced this pull request Nov 14, 2018
disksing added a commit that referenced this pull request Nov 14, 2018
* server, client: fix hanging problem when etcd failed to start (#1267)

* server: use same initialcluster config to restart joined member (#1279)

* fix server build

* pdctl: cherry pick bugfixes (#1298, #1299, #1308)

* server/api: fix the issue about `regions/check` API (#1311)

* fix join build

* fix pdctl build

* fix region test

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. type/bug The issue is confirmed as a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants