Skip to content

api: fix the encoded path of region key (#2399)#2577

Merged
ti-srebot merged 1 commit into
tikv:release-3.0from
rleungx:cherry-pick-2399
Jun 28, 2020
Merged

api: fix the encoded path of region key (#2399)#2577
ti-srebot merged 1 commit into
tikv:release-3.0from
rleungx:cherry-pick-2399

Conversation

@rleungx

@rleungx rleungx commented Jun 24, 2020

Copy link
Copy Markdown
Member

What problem does this PR solve?

cherry-pick #2399.

What is changed and how it works?

This PR uses UseEncodedPath to solve the %2F problem.

Check List

Tests

  • Unit test

Release note

  • Fix the 404 problem when using region key in pd-ctl

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added this to the v3.0.16 milestone Jun 24, 2020
@rleungx rleungx requested review from HunDunDM, disksing and nolouch June 24, 2020 08:18
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #2577 into release-3.0 will decrease coverage by 0.08%.
The diff coverage is 40.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2577      +/-   ##
===============================================
- Coverage        69.89%   69.81%   -0.09%     
===============================================
  Files              171      171              
  Lines            16983    16987       +4     
===============================================
- Hits             11870    11859      -11     
- Misses            4141     4150       +9     
- Partials           972      978       +6     
Impacted Files Coverage Δ
server/api/region.go 68.33% <25.00%> (-0.74%) ⬇️
server/api/router.go 100.00% <100.00%> (ø)
pkg/tempurl/tempurl.go 57.14% <0.00%> (-14.29%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0.00%> (-9.31%) ⬇️
server/schedulers/shuffle_hot_region.go 58.97% <0.00%> (-6.42%) ⬇️
server/region_syncer/client.go 78.94% <0.00%> (-2.64%) ⬇️
server/util.go 72.61% <0.00%> (-2.55%) ⬇️
server/leader.go 77.91% <0.00%> (-2.50%) ⬇️
server/cluster.go 81.72% <0.00%> (-1.02%) ⬇️
server/handler.go 51.87% <0.00%> (+0.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0963de...6d6af9b. Read the comment docs.

@disksing

Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2020
@ti-srebot

Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 899e122 into tikv:release-3.0 Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants