Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make SrcToleranceRatio and DstToleranceRatio enable for stddev #5546

Merged
merged 4 commits into from Sep 23, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 22, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Ref #5545

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

 None.

…r `stddev`

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 75.47% // Head: 75.63% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (c40490f) compared to base (02f5639).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c40490f differs from pull request most recent head b695dd8. Consider uploading reports for the commit b695dd8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5546      +/-   ##
==========================================
+ Coverage   75.47%   75.63%   +0.15%     
==========================================
  Files         326      326              
  Lines       32276    32281       +5     
==========================================
+ Hits        24360    24415      +55     
+ Misses       5805     5768      -37     
+ Partials     2111     2098      -13     
Flag Coverage Δ
unittests 75.63% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region_config.go 92.54% <ø> (ø)
server/schedulers/hot_region.go 85.34% <100.00%> (-0.20%) ⬇️
server/schedulers/hot_region_v2.go 73.09% <100.00%> (+1.50%) ⬆️
server/cluster/cluster.go 82.58% <0.00%> (-0.54%) ⬇️
client/base_client.go 82.77% <0.00%> (-0.48%) ⬇️
server/cluster/unsafe_recovery_controller.go 80.91% <0.00%> (-0.36%) ⬇️
client/client.go 69.52% <0.00%> (-0.22%) ⬇️
server/grpc_service.go 49.36% <0.00%> (+0.25%) ⬆️
server/handler.go 53.08% <0.00%> (+0.38%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c40490f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2022
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 85ace3d into tikv:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants