Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add Makefile for msc #5856

Merged
merged 2 commits into from
Jan 13, 2023
Merged

*: add Makefile for msc #5856

merged 2 commits into from
Jan 13, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 12, 2023

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5851.

What is changed and how does it work?

Let make check work for msc.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 74.91% // Head: 75.63% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (cc84857) compared to base (364a1e1).
Patch has no changes to coverable lines.

❗ Current head cc84857 differs from pull request most recent head 6f3db0a. Consider uploading reports for the commit 6f3db0a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5856      +/-   ##
==========================================
+ Coverage   74.91%   75.63%   +0.72%     
==========================================
  Files         335      337       +2     
  Lines       34094    34137      +43     
==========================================
+ Hits        25540    25819     +279     
+ Misses       6359     6101     -258     
- Partials     2195     2217      +22     
Flag Coverage Δ
unittests 75.63% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tso/tso.go 65.73% <0.00%> (-5.62%) ⬇️
pkg/dashboard/adapter/manager.go 77.01% <0.00%> (-4.60%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/region_syncer/server.go 81.86% <0.00%> (-1.10%) ⬇️
pkg/member/member.go 64.21% <0.00%> (-1.06%) ⬇️
server/schedulers/evict_leader.go 78.57% <0.00%> (-0.90%) ⬇️
server/handler.go 52.88% <0.00%> (-0.39%) ⬇️
server/cluster/unsafe_recovery_controller.go 78.70% <0.00%> (-0.35%) ⬇️
server/region_syncer/client.go 86.56% <0.00%> (ø)
pkg/mcs/resource_manager/server/install/install.go 100.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest lgtm

@@ -46,6 +46,3 @@ enable-codegen:
disable-codegen:
cd ../../ && $(MAKE) failpoint-disable
go mod tidy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use it.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2023
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 13, 2023
@rleungx
Copy link
Member Author

rleungx commented Jan 13, 2023

I'm going to merge this PR. I have no idea why there are two approve but only get one LGTM label.

@rleungx
Copy link
Member Author

rleungx commented Jan 13, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fb48c14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2023
@rleungx
Copy link
Member Author

rleungx commented Jan 13, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a384bd4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2023
@ti-chi-bot ti-chi-bot merged commit 6be27aa into tikv:master Jan 13, 2023
@rleungx rleungx deleted the add-makefile branch January 13, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants