Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: sync store state to scheduling service #7047

Merged
merged 2 commits into from
Sep 6, 2023
Merged

mcs: sync store state to scheduling service #7047

merged 2 commits into from
Sep 6, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 5, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

This PR synchronizes the changed state to the scheduling service because the heartbeat only reports the statistics.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 5, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and Yisaer September 5, 2023 10:00
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 5, 2023
@rleungx rleungx requested review from JmPotato and lhy1024 and removed request for disksing and Yisaer September 5, 2023 10:05
@rleungx rleungx force-pushed the sync-store-state branch 2 times, most recently from 8a29d4f to 02a6f12 Compare September 6, 2023 02:44
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #7047 (8b72956) into master (745c942) will decrease coverage by 0.11%.
The diff coverage is 85.22%.

@@            Coverage Diff             @@
##           master    #7047      +/-   ##
==========================================
- Coverage   74.38%   74.28%   -0.11%     
==========================================
  Files         435      436       +1     
  Lines       46357    46411      +54     
==========================================
- Hits        34484    34475       -9     
- Misses       8850     8897      +47     
- Partials     3023     3039      +16
Flag Coverage Δ
unittests 74.28% <85.22%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

JmPotato
JmPotato approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reset LGTM.

pkg/mcs/scheduling/server/meta/watcher.go
store := &metapb.Store{}
if err := proto.Unmarshal(kv.Value, store); err != nil {
log.Warn("failed to unmarshal store entry",
zap.String("event-kv-key", string(kv.Key)), zap.Error(err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to call ExtractStoreIDFromPath to get the store ID here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to add it to the log?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2023
@rleungx
sync store state to scheduling service
dcd2233 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Sep 6, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023
@rleungx
Copy link
Member Author

rleungx commented Sep 6, 2023

/merge cancel

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023
@rleungx
tiny fix
8b72956 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Sep 6, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8b72956

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8e76ada into tikv:master Sep 6, 2023
26 checks passed
@rleungx rleungx deleted the sync-store-state branch September 6, 2023 06:30
@rleungx rleungx mentioned this pull request Sep 6, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
mcs: sync store state to scheduling service (tikv#7047)
a9995c0 
ref tikv#5839

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @JmPotato @lhy1024