Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support *not* generating protobuf structs #2

Merged
merged 2 commits into from Apr 4, 2019
Merged

Support *not* generating protobuf structs #2

merged 2 commits into from Apr 4, 2019

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 4, 2019

Signed-off-by: ice1000 ice1000kotlin@foxmail.com

Because raft-rs has almost eliminated all protobuf stuffs, I wonder if we can have an option to not generate protobuf::Message implementation but only the getter setter wrapper.

Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
Copy link
Collaborator

@nrc nrc left a comment

Thanks for the PR, seems like a sensible thing to do!

src/wrapper.rs Outdated Show resolved Hide resolved
src/wrapper.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented Apr 4, 2019

All comments addressed, PTALA

src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
@nrc nrc merged commit 02bcec1 into tikv:master Apr 4, 2019
@nrc
Copy link
Collaborator

@nrc nrc commented Apr 4, 2019

Thanks!

@ice1000 ice1000 added the enhancement label Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants