Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support *not* generating protobuf structs #2

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@ice1000
Copy link
Member

commented Apr 4, 2019

Signed-off-by: ice1000 ice1000kotlin@foxmail.com

Because raft-rs has almost eliminated all protobuf stuffs, I wonder if we can have an option to not generate protobuf::Message implementation but only the getter setter wrapper.

Support *not* generating protobuf structs
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
@nrc
Copy link
Collaborator

left a comment

Thanks for the PR, seems like a sensible thing to do!

Show resolved Hide resolved src/wrapper.rs Outdated
Show resolved Hide resolved src/wrapper.rs Outdated
Show resolved Hide resolved src/lib.rs Outdated
@ice1000

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

All comments addressed, PTALA

Show resolved Hide resolved src/lib.rs Outdated
Address comments: use an `enum` instead of a `bool`, minor tweaks
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>

@nrc nrc merged commit 02bcec1 into tikv:master Apr 4, 2019

@nrc

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.