Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix powerpc detection #37

Merged
merged 2 commits into from Mar 31, 2020
Merged

fix powerpc detection #37

merged 2 commits into from Mar 31, 2020

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Mar 31, 2020

Appears rust's output is "powerpc64" instead of "ppc64le".

@BusyJay
fix powerpc detection
333e3f1 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay requested a review from nrc March 31, 2020 10:27
nrc
nrc approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@nrc nrc merged commit eae880d into tikv:master Mar 31, 2020
@BusyJay BusyJay deleted the fix-powerpc-detection branch April 1, 2020 03:24
@BusyJay BusyJay mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BusyJay @nrc