*: introduce confchange package #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package is ported from etcd/raft/confchange. restore function is not used yet. tests will be ported after all functional codes are ported. There is a difference between raft-rs and etcd that etcd shallow clones progress set in changer, but raft-rs only use reference and record changes. It's not easy to shallow clone in rust without lifetime hack or introducing redundant containers. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
@Fullstop000 PTAL if you have time. Thanks! |
gengliqi
reviewed
Jul 9, 2020
| } | ||
| cfg.voters | ||
| .outgoing | ||
| .extend(cfg.voters.incoming.iter().cloned()); |
There was a problem hiding this comment.
In etcd, the behavior is clear outgoing and copy incoming to outgoing.
There was a problem hiding this comment.
The check at L71 ensures that outgoing is empty. Assigning new empty map is necessary in etcd, because it uses nil map which can't be modified. But we use empty map that doesn't have the issue.
src/confchange/restore.rs
Outdated
| /// TODO(tbg) it's silly that this takes a Changer. Unravel this by making sure the | ||
| /// Changer only needs a ProgressMap (not a whole Tracker) at which point this can just | ||
| /// take LastIndex and MaxInflight directly instead and cook up the results from that | ||
| /// alone. |
There was a problem hiding this comment.
The annotation may should be updated?
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Connor1996
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is ported from etcd/raft/confchange. restore function is not
used yet. tests will be ported after all functional codes are ported.
There is a difference between raft-rs and etcd that etcd shallow clones
progress set in changer, but raft-rs only use reference and record
changes. It's not easy to shallow clone in rust without lifetime hack
or introducing redundant containers.