New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch split #6

Open
wants to merge 13 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@Connor1996
Member

Connor1996 commented Oct 25, 2018

No description provided.

Add batch split
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 force-pushed the Connor1996-patch-1 branch from 8bfcf46 to 27080ea Oct 25, 2018

some change
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996

This comment has been minimized.

Member

Connor1996 commented Oct 25, 2018

Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@queenypingcap

This comment has been minimized.

queenypingcap commented Oct 30, 2018

@lilin90 PTAL.

Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
Show resolved Hide resolved text/2018-10-25-batch-split.md Outdated
address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 force-pushed the Connor1996-patch-1 branch from aa2ea7c to 300f8b3 Nov 2, 2018

@siddontang siddontang referenced this pull request Nov 14, 2018

Open

move some design docs to rfcs #5

1 of 21 tasks complete

Connor1996 added some commits Nov 23, 2018

address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 force-pushed the Connor1996-patch-1 branch from 700a811 to 095d561 Nov 26, 2018

@Connor1996

This comment has been minimized.

Member

Connor1996 commented Nov 26, 2018

PTAL again

Connor1996 added some commits Nov 26, 2018

format
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
adjust format
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
fix grammar
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@huachaohuang

Rest LGTM, I think the writing is good :)

## Implementation in TiKV
### How to produce multiple split keys

This comment has been minimized.

@huachaohuang

huachaohuang Nov 28, 2018

Member

Do not overspecify the details in the RFC as doing so can bury the reviewer in minutiae.

IMO, this section is too detailed and not necessary.

simplify
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996

This comment has been minimized.

Member

Connor1996 commented Nov 28, 2018

PTAL again @huachaohuang

general logic of SizeChecker and KeysChecker are similar. The only difference
between them is one splits Region based on size and the other splits Region
based on the number of keys. So here we mainly describe the logic of
SizeChecker:

This comment has been minimized.

@huachaohuang

huachaohuang Nov 28, 2018

Member

Actually, I think the following two paragraphs are too verbose and not necessary.
These explanations are more suitable as comments in the code than in the RFC.

This comment has been minimized.

@Connor1996

Connor1996 Nov 30, 2018

Member

IMO, the algorithm should discussed in RFC stage.

@huachaohuang

LGTM

@huachaohuang

This comment has been minimized.

Member

huachaohuang commented Dec 5, 2018

@Connor1996 Try to get another approval :)

@Connor1996

This comment has been minimized.

Member

Connor1996 commented Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment