raftstore,util: address some review comments

Signed-off-by: Ben Pig Chu <benpichu@gmail.com>
tikv · Jun 6, 2019 · a6183d9 · a6183d9
1 parent 840a386
commit a6183d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/components/tikv_util/src/file.rs b/components/tikv_util/src/file.rs
@@ -202,5 +202,7 @@ mod tests {
     fn test_fsync_by_path() {
         let tmp_dir = TempDir::new("").unwrap();
         fsync_by_path(tmp_dir.path()).unwrap();
+        let non_existent_file = tmp_dir.join("non_existent_file");
+        fsync_by_path(tmp_dir.path()).unwrap_err();
     }
 }
diff --git a/src/raftstore/store/snap.rs b/src/raftstore/store/snap.rs
@@ -963,6 +963,7 @@ impl Snapshot for Snap {
             fs::rename(&cf_file.tmp_path, &cf_file.path)?;
             self.size_track.fetch_add(cf_file.size, Ordering::SeqCst);
         }
+        fsync_by_path(&self.dir_path)?;
         // write meta file
         let mut v = vec![];
         self.meta_file.meta.write_to_vec(&mut v)?;