New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging from backup-stream is noisy #14012
Comments
#13913 might be slightly related |
I guess #13913 won't make things worse because it only changes the format of the log but haven't changed when and how the logs being printed. 🤔 |
So I guess you don't start any log backup task right? It seems that once there isn't any log backup task, this log would be printed when a region get split or merged. Truly that is noisy, perhaps we'd better mute them once there isn't a task. |
close #14012 Added a "hibernate mode" for the log backup observer: while there isn't any task, it won't emit leader drop or region change events. So some verbose logs can be omitted. Signed-off-by: hillium <yujuncen@pingcap.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Bug Report
What version of TiKV are you using?
What operating system and CPU are you using?
Fedora Linux 37, Linux 6.0.12, Intel Core i7
Steps to reproduce
Run a TiUP Playground. Then run
tiup bench tpcc prepare
.What did you expect?
No noisy logging
What did happened?
grep 'subscription_track.rs:159' .tiup/data/TRUCY5d/tikv-0/tikv.log
This is with log format set to
json
.For users of TiKV it isn't clear if this indicates a problem or not. Note that these are warning messages.
If these message are normal and expected, then the level should probably be
INFO
.Note that this is a TiUP playground without any backup or PITR going on.
The text was updated successfully, but these errors were encountered: