Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit use of assert! and debug_assert! for bloat #4161

Closed
brson opened this issue Jan 31, 2019 · 1 comment
Closed

Audit use of assert! and debug_assert! for bloat #4161

brson opened this issue Jan 31, 2019 · 1 comment
Labels
component/build-time Component: Compilation time

Comments

@brson
Copy link
Contributor

brson commented Jan 31, 2019

assert! can cause an unexpected amount of code bloat that takes time to compile and fills up binary space to never ever be executed. See what its impact is on tikv.

A good way to start would be to simply convert all asserts to debug_asserts and benchmark, see if it's worth pursuing. Consider doing the same with tikv's raft and prometheus dependencies.

If it seems worth pursing then decide on a case-by-case basis which have the biggest impact and can be converted.

https://github.com/dtolnay/cargo-expand can probably help.

@brson brson added the component/build-time Component: Compilation time label Jan 31, 2019
@brson brson added this to To do in Improve compile times Feb 11, 2019
@brson
Copy link
Contributor Author

brson commented Sep 5, 2019

I don't think this is worth doing.

@brson brson closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build-time Component: Compilation time
Projects
Development

No branches or pull requests

1 participant