Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `extern crate` statements from the repo #4196

Open
brson opened this Issue Feb 11, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@brson
Copy link
Contributor

brson commented Feb 11, 2019

TiKV is on Rust 2018 now. That means that for the most part extern crate isn't needed. Remove all that you can.

Resources:

Note that the code in the fuzz directory is still on 2015, so don't change anything there.

@wujunze

This comment has been minimized.

Copy link
Contributor

wujunze commented Feb 14, 2019

Let me give this a try.
Thanks

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 15, 2019

It's all yours @wujunze !

@wujunze

This comment has been minimized.

Copy link
Contributor

wujunze commented Feb 17, 2019

OK @brson

@ICEYSELF

This comment has been minimized.

Copy link

ICEYSELF commented Feb 28, 2019

@wujunze Are you still working on this? If not, I will start.

@wujunze

This comment has been minimized.

Copy link
Contributor

wujunze commented Feb 28, 2019

I am doing Thanks

@wujunze

This comment has been minimized.

Copy link
Contributor

wujunze commented Feb 28, 2019

This task looks very interesting and you are welcome to complete it together @ICEYSELF
#4297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.