Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert trait objects to `dyn` traits #4197

Closed
brson opened this Issue Feb 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@brson
Copy link
Contributor

brson commented Feb 11, 2019

TiKV is using Rust 2018 now. Let's migrate to the dyn syntax for trait objects. This should be pretty easy with the #![deny(bare_trait_objects)] lint. Just apply that to the tikv crate root and fix all the errors.

Then do the same for the bins, tests and benches listed in Cargo.toml, and the same for the component projects in the components directory.

@crlf0710

This comment has been minimized.

Copy link
Contributor

crlf0710 commented Feb 14, 2019

let me give this a try.

ice1000 added a commit that referenced this issue Feb 27, 2019

Add `dyn` to trait object syntax. (#4197) (#4217)
Signed-off-by: CrLF0710 <crlf0710@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.