Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git dependency revisions explicit in Cargo.toml #4283

brson opened this Issue Feb 26, 2019 · 0 comments


None yet
1 participant
Copy link

brson commented Feb 26, 2019

Tikv has a number of git dependencies. Today the exact revision of those deps is maintained only in the lockfile.

It is more foolproof though to specify git revisions directly in Cargo.toml. If it's not there then the process of updating the lockfile can get unpleasant.

Find all the git deps in all the projects in the workspace and add a "rev = $sha" entry to each.

It may be the case that multiple projects in the workspace have the same git dep. I'm not sure if it's best to specify the revision in one project or all, but I suspect it's more foolproof to do it everywhere, with the hope that if the rev is only updated in one place that the build will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.