Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raft logs in CommitMerge should forward to raftstore first #4560

Closed
overvenus opened this issue Apr 23, 2019 · 2 comments
Assignees
Labels

Comments

@overvenus
Copy link
Contributor

@overvenus overvenus commented Apr 23, 2019

If a node is panicked when there is a region executing catch_up_logs_for_merge, then the node can not restart again, because when it executes catch_up_logs_for_mrege it may execute some committed logs that are not yet present in the peer_storage, this will lead to write an applied_index that is higher than the commit_index. When the node restarts it will panic due to applied_index > commit_index.

We can forward committed logs to raftstore, and write them to the peer_storage, then ask apply worker to apply the new committed raft logs.

@Hoverbear

This comment has been minimized.

Copy link
Member

@Hoverbear Hoverbear commented Sep 11, 2019

Hi @overvenus , can this be closed?

@overvenus

This comment has been minimized.

Copy link
Contributor Author

@overvenus overvenus commented Sep 12, 2019

Yes, #4595 and #4615 fixed the bug.

@overvenus overvenus closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.