Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error, panic, and log outputs from Debug to Display #4960

Open
breeswish opened this issue Jun 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@breeswish
Copy link
Member

commented Jun 24, 2019

Feature Request

Currently in many places we use Debug to output errors, which is not a good way since we mostly want customized outputs (like hex output keys).

@brson

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

"{:?}" is used to create error types, in log messages and in panic messages. "{}" should be used everywhere possible.

Exceptions where it's fine to use "{:?}" include in test cases and assertions. "{}" should still be preferred, but it's probably not worth introducing any extra code for them.

@brson brson changed the title Change error outputs from Debug to Display Change error, panic, and log outputs from Debug to Display Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.