Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an independent arena for gRPC allocation #5472

Open
siddontang opened this issue Sep 17, 2019 · 1 comment
Assignees

Comments

@siddontang
Copy link
Contributor

@siddontang siddontang commented Sep 17, 2019

Feature Request

Is your feature request related to a problem? Please describe:

Recently, from @shafreeck investigation, we have located that sometimes gRPC may cache a huge memory which may cause OOM. We may write an article to discuss it in detailed later.

Here, I think, the same as RocksDB, why not using an independent arena for gRPC, so we can trace the gRPC memory statistics easily and know the above problem better.

Describe the feature you'd like:

The gRPC has already provided an allocation hook, see https://github.com/grpc/grpc/blob/master/include/grpc/support/alloc.h#L30, what we should do is very easy, just follow the usage of RocksDB https://github.com/facebook/rocksdb/blob/8843129ecef255a70f186e095063b4e79b2b0c73/memory/jemalloc_nodump_allocator.cc, to build an allocator.

Describe alternatives you've considered:

No

Teachability, Documentation, Adoption, Migration Strategy:

No

/cc @zhangjinpeng1987

@zhangjinpeng1987

This comment has been minimized.

Copy link
Member

@zhangjinpeng1987 zhangjinpeng1987 commented Oct 11, 2019

After we set memory quota for gRPC, i think we can give this task low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.