New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: fix uploading to gcs error #13107
Conversation
Signed-off-by: WangLe1321 <wangle1321@163.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check-issue-triage-complete |
/run check-issue-triage-complete |
/cc @3pointer @overvenus |
/check-issue-triage-complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mock a storage that checks the given est_len
and reader content strictly?
Signed-off-by: WangLe1321 <wangle1321@163.com>
/merge |
@overvenus: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1da3f65
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.2 in PR #13140 |
Signed-off-by: WangLe1321 wangle1321@163.com
What is changed and how it works?
Issue Number: Close #13106
What's Changed:
Modify
est_len
to real file size, so that the value ofcontent-length
in http header is equal to the size of http body when put object to gcs.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
test steps and test results is described in this document
Side effects
Release note