Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: fix uploading to gcs error #13107

Merged
merged 4 commits into from Jul 27, 2022
Merged

log-backup: fix uploading to gcs error #13107

merged 4 commits into from Jul 27, 2022

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Jul 22, 2022 •
edited

Signed-off-by: WangLe1321 wangle1321@163.com

What is changed and how it works?

Issue Number: Close #13106

What's Changed:

Modify est_len to real file size, so that the value of content-length in http header is equal to the size of http body when put object to gcs.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    test steps and test results is described in this document

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

support gcs storage in log backup

@WangLe1321
log-backup: fix uploading to gcs error
1349107 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@WangLe1321
Copy link
Contributor Author

/run-check-issue-triage-complete

@WangLe1321
Copy link
Contributor Author

/run check-issue-triage-complete

@WangLe1321
Copy link
Contributor Author

/cc @3pointer @overvenus

@WangLe1321
Copy link
Contributor Author

/check-issue-triage-complete

overvenus
overvenus reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mock a storage that checks the given est_len and reader content strictly?

@WangLe1321
log-backup: add unit test for est_len
1da3f65 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot ti-chi-bot added size/M and removed size/XS labels Jul 27, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Jul 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 27, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1da3f65

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Jul 27, 2022
@ti-chi-bot ti-chi-bot merged commit f5adcb1 into tikv:master Jul 27, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jul 27, 2022
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request Jul 27, 2022
@WangLe1321 @ti-srebot
cherry pick tikv#13107 to release-6.2
f7cf18f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2022
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #13140

ti-chi-bot pushed a commit that referenced this pull request Jul 27, 2022
@ti-srebot @WangLe1321
log-backup: fix uploading to gcs error (#13107) (#13140)
775dc79 
close #13106, ref #13107

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangLe1321 <wangle1321@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors first-time-contributor needs-cherry-pick-release-6.2 release-note size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

log backup failed when use GCS as external storage
5 participants
@WangLe1321 @ti-chi-bot @overvenus @ti-srebot @3pointer