Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify logger #1476

Merged
merged 1 commit into from Jan 8, 2017

Conversation

@BusyJay
Copy link
Contributor

commented Jan 7, 2017

This pr unify logger's implementations.

  1. change logging format to be near the same as pingcap/tidb and pingcap/pd, except that we keep microseconds in time part.
  2. make all the loggers inside TiKV project to use the same log format.

ref #1475

@andelf

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2017

CircleCI failed, due to old cache.
I'll fix it by rebuild without cache.

@andelf
andelf approved these changes Jan 7, 2017
Copy link
Contributor

left a comment

LGTM

@ngaut

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

LGTM

@ngaut ngaut merged commit c7bc163 into master Jan 8, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@ngaut ngaut deleted the busyjay/unify-logger branch Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.