New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch send apply_proposals to apply worker #2051

Merged
merged 5 commits into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@lishuai87
Contributor

lishuai87 commented Jul 18, 2017

No description provided.

@lishuai87 lishuai87 requested review from siddontang, BusyJay and overvenus Jul 18, 2017

Show outdated Hide outdated src/raftstore/store/worker/apply.rs
region_id: region_id,
props: props,
})
pub fn proposals(proposals: Vec<RegionProposal>) -> Task {

This comment has been minimized.

@BusyJay

BusyJay Jul 18, 2017

Contributor

The method is redundant.

@BusyJay

BusyJay Jul 18, 2017

Contributor

The method is redundant.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Jul 18, 2017

Contributor

any benchmark?

Contributor

siddontang commented Jul 18, 2017

any benchmark?

Show outdated Hide outdated src/raftstore/store/peer.rs
@@ -642,14 +642,14 @@ impl Peer {
self.get_store().applied_index_term == self.term()
}
pub fn schedule_apply_proposals(&mut self, worker: &Worker<ApplyTask>) {
pub fn schedule_apply_proposals(&mut self) -> Option<RegionProposal> {

This comment has been minimized.

@siddontang

siddontang Jul 19, 2017

Contributor

The schedule in the function name is not proper here now.

@siddontang

siddontang Jul 19, 2017

Contributor

The schedule in the function name is not proper here now.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Jul 19, 2017

Contributor

LGTM

PTAL @BusyJay

Contributor

siddontang commented Jul 19, 2017

LGTM

PTAL @BusyJay

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Jul 21, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Jul 21, 2017

PTAL @BusyJay

@BusyJay

LGTM

@lishuai87 lishuai87 merged commit cf7b683 into master Jul 21, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@lishuai87 lishuai87 deleted the javaforfun/batch-apply-proposals branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment