New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap refactor 1: remove v1 #2053

Merged
merged 4 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants

Cholerae Hu added some commits Jul 12, 2017

Cholerae Hu
*: remove all snap v1 api and tests
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
snap: remove used test
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
peer: remove unused test
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@@ -988,26 +471,18 @@ mod v2 {
return Ok(());
}
for cf_file in &mut self.cf_files {
if plain_file_used(cf_file.cf) {

This comment has been minimized.

@siddontang

siddontang Jul 19, 2017

Contributor

is it proper to use SST for lock CF? @zhangjinpeng1987

@siddontang

siddontang Jul 19, 2017

Contributor

is it proper to use SST for lock CF? @zhangjinpeng1987

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Jul 19, 2017

Member

It is too expensive for lock cf to use sst file.

@zhangjinpeng1987

zhangjinpeng1987 Jul 19, 2017

Member

It is too expensive for lock cf to use sst file.

This comment has been minimized.

@choleraehyq

choleraehyq Jul 19, 2017

I totally remove v1 related code in this PR to keep clear. CF_LOCK will return to use plain file in another PR.

@choleraehyq

choleraehyq Jul 19, 2017

I totally remove v1 related code in this PR to keep clear. CF_LOCK will return to use plain file in another PR.

This comment has been minimized.

@siddontang

siddontang Jul 19, 2017

Contributor

😓 Please add a comment here.

@siddontang

siddontang Jul 19, 2017

Contributor

😓 Please add a comment here.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Jul 19, 2017

Contributor

Rest LGTM

Contributor

siddontang commented Jul 19, 2017

Rest LGTM

Cholerae Hu
snap: add comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@zhangjinpeng1987

This comment has been minimized.

Show comment
Hide comment
Member

zhangjinpeng1987 commented Jul 19, 2017

LGTM

@siddontang siddontang merged commit f3772dd into pre-ga Jul 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the hyq/removev1 branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment