New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr/dag: add builtin conditions #2198

Merged
merged 40 commits into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@choleraehyq

choleraehyq commented Aug 22, 2017

Cholerae Hu added some commits Aug 18, 2017

Cholerae Hu
dag: add builtin scalar func op 1
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: add more builtin
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: add duration_is_null
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: reformat
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: add builtin_control
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: builtin_control done
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix bugs
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix a bug about float and 0
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix some stupid bugs
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: add tests
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix argument check bug
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: pass tests
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: remove builtin_control
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: make clippy happy
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: make rustfmt happy
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix a bug in real_is_true
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: reformat
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: use try_opt to simplified codes
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: use map_or to replace unwrap
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix logical_or bug
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
copr/expression: add builtin condition
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: make clippy happy
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>

Cholerae Hu added some commits Aug 22, 2017

Cholerae Hu
dag: add builtin control in fncall
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: fix cmp compile error
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
dag: replace tt with (op, lhs, rhs, exp)
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>

@choleraehyq choleraehyq changed the title from [DNM] copr/dag: add builtin conditions to copr/dag: add builtin conditions Aug 22, 2017

Cholerae Hu added some commits Aug 22, 2017

Show outdated Hide outdated src/coprocessor/dag/expr/builtin_control.rs Outdated
Show outdated Hide outdated src/coprocessor/dag/expr/builtin_control.rs Outdated
Show outdated Hide outdated src/coprocessor/dag/expr/builtin_control.rs Outdated
Show outdated Hide outdated src/coprocessor/dag/expr/builtin_control.rs Outdated

Cholerae Hu added some commits Aug 23, 2017

Cholerae Hu
dag: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@choleraehyq

This comment has been minimized.

Show comment
Hide comment
@choleraehyq

choleraehyq commented Aug 23, 2017

Show outdated Hide outdated src/coprocessor/dag/expr/builtin_control.rs Outdated
fn test_if_null() {
let tests = vec![
(
ScalarFuncSig::IfNullInt,

This comment has been minimized.

@BusyJay

BusyJay Aug 23, 2017

Contributor

Should check Datum::I64(0).

@BusyJay

BusyJay Aug 23, 2017

Contributor

Should check Datum::I64(0).

Cholerae Hu
expression: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@choleraehyq

This comment has been minimized.

Show comment
Hide comment
@choleraehyq

choleraehyq commented Aug 23, 2017

Cholerae Hu added some commits Aug 23, 2017

Cholerae Hu
coprocessor: fix bug in test_if_null
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
coprocessor: remove all Ok(try!())
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@AndreMouche

LGTM

@AndreMouche AndreMouche merged commit eb81d16 into master Aug 23, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the hyq/scalarcondition branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment