New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: add statistics back #2200

Merged
merged 15 commits into from Aug 28, 2017

Conversation

Projects
None yet
5 participants
@choleraehyq

choleraehyq commented Aug 23, 2017

@overvenus @siddontang @AndreMouche PTAL

Signed-off-by: Cholerae Hu huyingqian@pingcap.com

Cholerae Hu
cop: add statistics
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>

Cholerae Hu added some commits Aug 23, 2017

Cholerae Hu
threadpool: modify WORKER_WAIT_TIME and DEFAULT_TASKS_PER_TICK
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
cop: reduce clone
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Show outdated Hide outdated src/coprocessor/endpoint.rs
Show outdated Hide outdated src/storage/engine/mod.rs
Show outdated Hide outdated src/storage/engine/mod.rs

Cholerae Hu added some commits Aug 23, 2017

Cholerae Hu
*: address comment
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
threadpool: modify some config
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@siddontang

LGTM

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Contributor

siddontang commented Aug 24, 2017

Cholerae Hu added some commits Aug 24, 2017

Cholerae Hu
cop: reset statistics in context in on_tick
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
Cholerae Hu
cop: use average stats
Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>

sadf

Signed-off-by: Cholerae Hu <huyingqian@pingcap.com>
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Aug 27, 2017

Contributor

please fix the conflict.

PTAL @zhangjinpeng1987 @BusyJay

Contributor

siddontang commented Aug 27, 2017

please fix the conflict.

PTAL @zhangjinpeng1987 @BusyJay

Cholerae Hu added some commits Aug 28, 2017

@choleraehyq choleraehyq merged commit c8b8e63 into master Aug 28, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@choleraehyq choleraehyq deleted the hyq/copstats branch Aug 28, 2017

for (tag, count) in details {
COPR_SCAN_DETAILS
.with_label_values(&[type_str, cf, tag])
.observe(count as f64 / task_count as f64);

This comment has been minimized.

@zhangjinpeng1987

zhangjinpeng1987 Aug 28, 2017

Member

How about task_count is 0.

@zhangjinpeng1987

zhangjinpeng1987 Aug 28, 2017

Member

How about task_count is 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment