New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move heartbeat approximate size to worker. #2205

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@huachaohuang
Member

huachaohuang commented Aug 23, 2017

No description provided.

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Aug 24, 2017

Contributor

handle_store_heartbeat also passes engine, you can use the DB field too, please refactor it later.

LGTM

Contributor

siddontang commented Aug 24, 2017

handle_store_heartbeat also passes engine, you can use the DB field too, please refactor it later.

LGTM

@huachaohuang huachaohuang merged commit df6fcae into master Aug 24, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@huachaohuang huachaohuang deleted the huachao/heartbeat branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment