GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No description provided.
coprocessor, dag: add more math functions.
Merge branch 'master' into qupeng/expr-math
@AndreMouche @BusyJay , PTAL, thanks.
Any test to cover this?
Yes, but they are in coprocessor/dag/expr/math.rs.
They are different. The unit test for this function should focus on its functionality, while tests in math.rs is used to validate if the eval is implemented correctly.
Merge branch 'qupeng/expr-math' of github.com:pingcap/tikv into qupen…
format code for CI.
How about 1.000?
@BusyJay , I fixed. PTAL again, thanks.
Can it contain unsigned flag?
If it contains unsigned flag, TiDB will push down AbsUintSig.
Here I keep old code because op.eval_int(...) returns an i64 with sign. If we put it into a Datum, We can't compare it with another Datum::U64(number). @BusyJay
@BusyJay , PTAL, thanks.
make CI happy.
make ci happy.