New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr/builtin_cast: implement test_cast_as_real & test_cast_as_int #2218

Merged
merged 12 commits into from Aug 31, 2017

Conversation

Projects
None yet
3 participants
@AndreMouche
Member

AndreMouche commented Aug 28, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Aug 30, 2017

Contributor

Add more cases which can causes Overflow? e.g. cast big decimal as int.
You can do that after you fix two TODO in cast_decimal_as_int in builtin_cast.rs.
LGTM.

Contributor

hicqu commented Aug 30, 2017

Add more cases which can causes Overflow? e.g. cast big decimal as int.
You can do that after you fix two TODO in cast_decimal_as_int in builtin_cast.rs.
LGTM.

@hicqu

hicqu approved these changes Aug 30, 2017

@AndreMouche AndreMouche merged commit 1ed5738 into master Aug 31, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the shirly/eval_cast_test branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment