New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr/builtin_cast: implement eval for expression #2224

Merged
merged 17 commits into from Aug 31, 2017

Conversation

Projects
None yet
3 participants
@AndreMouche
Member

AndreMouche commented Aug 29, 2017

Show outdated Hide outdated src/coprocessor/dag/expr/mod.rs
Show outdated Hide outdated src/coprocessor/dag/expr/mod.rs
Show outdated Hide outdated src/coprocessor/dag/expr/mod.rs
@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Aug 30, 2017

Contributor

LGTM

Contributor

BusyJay commented Aug 30, 2017

LGTM

});
let res = filter(eval_int)
.or_else(|| filter(self.eval_real(ctx, row)))

This comment has been minimized.

@hicqu

hicqu Aug 30, 2017

Contributor

we match many times. Would it cause performance lose? @BusyJay

@hicqu

hicqu Aug 30, 2017

Contributor

we match many times. Would it cause performance lose? @BusyJay

This comment has been minimized.

@BusyJay

BusyJay Aug 30, 2017

Contributor

I think this is only for test purpose.

@BusyJay

BusyJay Aug 30, 2017

Contributor

I think this is only for test purpose.

This comment has been minimized.

@BusyJay

BusyJay Aug 30, 2017

Contributor

Let's merge it first to get things working first. I will figure out a way to reduce the lose.

@BusyJay

BusyJay Aug 30, 2017

Contributor

Let's merge it first to get things working first. I will figure out a way to reduce the lose.

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Aug 31, 2017

Contributor

LGTM.

Contributor

hicqu commented Aug 31, 2017

LGTM.

@hicqu

hicqu approved these changes Aug 31, 2017

@hicqu hicqu merged commit 1ed8540 into master Aug 31, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the shirly/dag_expr branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment