New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add tests for config sturcts #2230

Merged
merged 25 commits into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@overvenus
Member

overvenus commented Aug 30, 2017

Add missing tests for those structs.

@overvenus overvenus requested review from siddontang and BusyJay Aug 30, 2017

Show outdated Hide outdated src/config.rs
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Aug 31, 2017

Contributor

PTAL @BusyJay

Contributor

siddontang commented Aug 31, 2017

PTAL @BusyJay

Show outdated Hide outdated src/config.rs
Show outdated Hide outdated src/config.rs

overvenus added some commits Sep 5, 2017

Revert "add tests"
This reverts commit 59a4cc5.
@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 6, 2017

Member

PTAL

Member

overvenus commented Sep 6, 2017

PTAL

Show outdated Hide outdated src/config/mod.rs
@siddontang

LGTM

siddontang and others added some commits Sep 8, 2017

@overvenus overvenus merged commit ddce5ad into master Sep 8, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the ov/cfg-tests branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment