New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: adjust decimal parsing interface #2232

Merged
merged 7 commits into from Sep 1, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Aug 30, 2017

So when calling from_bytes, no utf8 validation is performed.

@BusyJay BusyJay requested review from AndreMouche and hicqu Aug 30, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Aug 31, 2017

Contributor

LGTM.

Contributor

hicqu commented Aug 31, 2017

LGTM.

@hicqu

hicqu approved these changes Aug 31, 2017

@BusyJay BusyJay merged commit 3da148f into master Sep 1, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/use-bytes-by-default branch Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment