New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests for grpc services #2244

Merged
merged 10 commits into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@overvenus
Member

overvenus commented Sep 1, 2017

Close #2058

@overvenus overvenus requested review from siddontang, BusyJay and disksing Sep 1, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 6, 2017

Contributor

@disksing PTAL

Contributor

BusyJay commented Sep 6, 2017

@disksing PTAL

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 7, 2017

Contributor

LGTM

Contributor

disksing commented Sep 7, 2017

LGTM

@siddontang

Rest LGTM

@overvenus overvenus merged commit 09b6fea into tikv:master Sep 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the overvenus:ov/service-tests branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment