New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor, dag: add json functions. #2246

Merged
merged 17 commits into from Sep 6, 2017

Conversation

Projects
None yet
4 participants
@hicqu
Contributor

hicqu commented Sep 2, 2017

No description provided.

@@ -176,6 +178,8 @@ impl FnCall {
ScalarFuncSig::IfTime |
ScalarFuncSig::IfDuration => (3, 3),
ScalarFuncSig::JsonArraySig | ScalarFuncSig::JsonObjectSig => (0, usize::MAX),

This comment has been minimized.

@AndreMouche

This comment has been minimized.

@hicqu

hicqu Sep 5, 2017

Contributor

It's a TiDB bug. I will fix that.

@hicqu

hicqu Sep 5, 2017

Contributor

It's a TiDB bug. I will fix that.

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 5, 2017

Collaborator

/rebuild

Collaborator

iamxy commented Sep 5, 2017

/rebuild

hicqu added some commits Sep 6, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 6, 2017

Contributor

@BusyJay , PTAL.

Contributor

hicqu commented Sep 6, 2017

@BusyJay , PTAL.

AndreMouche and others added some commits Sep 6, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 6, 2017

Contributor

@BusyJay , PTAL again, thanks.

Contributor

hicqu commented Sep 6, 2017

@BusyJay , PTAL again, thanks.

@AndreMouche

LGTM

@hicqu hicqu merged commit caea4f1 into master Sep 6, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the qupeng/expr-json branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment