New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv-ctl: add short name for raftdb #2249

Merged
merged 3 commits into from Sep 5, 2017

Conversation

Projects
None yet
4 participants
@lishuai87
Contributor

lishuai87 commented Sep 4, 2017

currently:

$./tikv-ctl -d data/db/ --raftdb data/raft/  raft region
error: Found argument '--raftdb' which wasn't expected, or isn't valid in this context

$ ./tikv-ctl -d data/db/ <raftdb> data/raft/  raft region
-bash: raftdb: No such file or directory

$ ./tikv-ctl -d data/db/  data/raft/  raft region

we should make -r work

$./tikv-ctl -d data/db/ -r data/raft/  raft region
@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 4, 2017

Contributor

Can it take a default value?

Contributor

BusyJay commented Sep 4, 2017

Can it take a default value?

let raft_db = if let Some(raftdb_path) = matches.value_of("raftdb") {
util::rocksdb::open(raftdb_path, &[CF_DEFAULT]).unwrap()
} else {
let raftdb_path = db_path.to_owned() + "../raft";

This comment has been minimized.

@siddontang

siddontang Sep 4, 2017

Contributor

do you test it?

@siddontang

siddontang Sep 4, 2017

Contributor

do you test it?

This comment has been minimized.

@lishuai87

lishuai87 Sep 5, 2017

Contributor

of course i've tested it

@lishuai87

lishuai87 Sep 5, 2017

Contributor

of course i've tested it

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 4, 2017

Contributor

Rest LGTM

Contributor

siddontang commented Sep 4, 2017

Rest LGTM

@siddontang siddontang merged commit adf328c into master Sep 5, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the javaforfun/tikv-ctl-raftdb branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment