New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/threadpool: cleanup #2250

Merged
merged 7 commits into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Sep 4, 2017

  • clean up code
  • add a default context implementation, which will be used to help replacing all other threadpool in TiKV
  • adjust poll strategy, so it won't wake up too frequently
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 4, 2017

Contributor

Rest LGTM

Contributor

siddontang commented Sep 4, 2017

Rest LGTM

BusyJay added some commits Sep 5, 2017

@siddontang

LGTM

BusyJay added some commits Sep 6, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 6, 2017

Contributor

/run-all-tests

Contributor

BusyJay commented Sep 6, 2017

/run-all-tests

Show outdated Hide outdated src/bin/tikv-ctl.rs
@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 7, 2017

Contributor

PTAL

Contributor

BusyJay commented Sep 7, 2017

PTAL

@overvenus

This comment has been minimized.

Show comment
Hide comment
@overvenus

overvenus Sep 7, 2017

Member

LGTM

Member

overvenus commented Sep 7, 2017

LGTM

@BusyJay BusyJay merged commit 6bbbccc into master Sep 7, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/remove-threadpool branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment