New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv-server: fix capacity parsing #2251

Merged
merged 5 commits into from Sep 6, 2017

Conversation

Projects
None yet
4 participants
@BusyJay
Contributor

BusyJay commented Sep 4, 2017

This pr tries to enable readable int parsing for args and print error message to stderr when log service is unavailable yet.

@BusyJay BusyJay requested review from siddontang, overvenus and tennix Sep 4, 2017

Show outdated Hide outdated src/util/config.rs
@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 4, 2017

Contributor

/run-all-tests

Contributor

BusyJay commented Sep 4, 2017

/run-all-tests

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 4, 2017

Contributor

Better to split into two PRs, one for fatal_stderr and one for readable size.

Contributor

siddontang commented Sep 4, 2017

Better to split into two PRs, one for fatal_stderr and one for readable size.

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 5, 2017

Collaborator

/rebuild

Collaborator

iamxy commented Sep 5, 2017

/rebuild

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 5, 2017

Collaborator

/run-all-test

Collaborator

iamxy commented Sep 5, 2017

/run-all-test

@siddontang

LGTM

@siddontang siddontang merged commit b62899e into master Sep 6, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the busyjay/fix-parse branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment