New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn/scheduler: fix unwrap panic #2253

Merged
merged 3 commits into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@overvenus
Member

overvenus commented Sep 4, 2017

finish_with_err() access grouped_cmds for enqueueing
conflicted commands, but the grouped_cmds is None.
We should restore grouped_cmds before further accessing.

txn/scheduler: fix unwrap panic
`finish_with_err()` access `grouped_cmds` for enqueueing
conflicted commands, but the `grouped_cmds` is None.
We should restore `grouped_cmds` before further accessing.

@BusyJay BusyJay requested a review from AndreMouche Sep 4, 2017

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Sep 4, 2017

Contributor

LGTM

Contributor

siddontang commented Sep 4, 2017

LGTM

@zhangjinpeng1987 zhangjinpeng1987 merged commit 9c78b40 into master Sep 5, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhangjinpeng1987 zhangjinpeng1987 deleted the ov/fix-scheduler-none-map branch Sep 5, 2017

overvenus added a commit that referenced this pull request Sep 5, 2017

@overvenus overvenus restored the ov/fix-scheduler-none-map branch Sep 11, 2017

@overvenus overvenus deleted the ov/fix-scheduler-none-map branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment