New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor/dag: use expression in dag #2261

Merged
merged 31 commits into from Sep 25, 2017

Conversation

Projects
None yet
4 participants
@AndreMouche
Member

AndreMouche commented Sep 7, 2017

@AndreMouche AndreMouche changed the title from coprocessor/dag: use expression in dag to [DNM]coprocessor/dag: use expression in dag Sep 8, 2017

@AndreMouche AndreMouche changed the title from [DNM]coprocessor/dag: use expression in dag to coprocessor/dag: use expression in dag Sep 12, 2017

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche
Member

AndreMouche commented Sep 12, 2017

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 14, 2017

Contributor

/run-all-tests

Contributor

BusyJay commented Sep 14, 2017

/run-all-tests

Show outdated Hide outdated src/coprocessor/dag/executor/mod.rs
Ok(AggrFuncExpr { args: args, tp: tp })
}
fn eval_args(&self, ctx: &EvalContext, row: &[Datum]) -> Result<Vec<Datum>> {

This comment has been minimized.

@BusyJay

BusyJay Sep 14, 2017

Contributor

s/eval_args/eval/

@BusyJay

BusyJay Sep 14, 2017

Contributor

s/eval_args/eval/

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 18, 2017

Contributor

rest LGTM.

Contributor

hicqu commented Sep 18, 2017

rest LGTM.

@hicqu

hicqu approved these changes Sep 18, 2017

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 18, 2017

Member

/run-all-tests

Member

AndreMouche commented Sep 18, 2017

/run-all-tests

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche
Member

AndreMouche commented Sep 18, 2017

use coprocessor::metrics::*;
use coprocessor::Result;
use super::{inflate_with_col_for_dag, Executor, ExprColumnRefVisitor, Row};
struct AggrFuncExpr {

This comment has been minimized.

@BusyJay

BusyJay Sep 18, 2017

Contributor

Can this be merged with AggrFunc?

@BusyJay

BusyJay Sep 18, 2017

Contributor

Can this be merged with AggrFunc?

This comment has been minimized.

@AndreMouche

AndreMouche Sep 19, 2017

Member

address comments

@AndreMouche

AndreMouche Sep 19, 2017

Member

address comments

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 19, 2017

Member

/run-all-tests

Member

AndreMouche commented Sep 19, 2017

/run-all-tests

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 19, 2017

Contributor

CI fail.

Contributor

BusyJay commented Sep 19, 2017

CI fail.

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 20, 2017

Member

/run-all-tests

Member

AndreMouche commented Sep 20, 2017

/run-all-tests

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 21, 2017

Contributor

/rebuild

Contributor

coocood commented Sep 21, 2017

/rebuild

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 22, 2017

Member

/run-all-tests tidb=hanfei/ci

Member

AndreMouche commented Sep 22, 2017

/run-all-tests tidb=hanfei/ci

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 22, 2017

Member

/run-all-tests tidb=hanfei/ci

Member

AndreMouche commented Sep 22, 2017

/run-all-tests tidb=hanfei/ci

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 22, 2017

Member

/run-all-tests tidb=hanfei/ci

Member

AndreMouche commented Sep 22, 2017

/run-all-tests tidb=hanfei/ci

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 22, 2017

Member

/run-all-tests tidb=hanfei/ci

Member

AndreMouche commented Sep 22, 2017

/run-all-tests tidb=hanfei/ci

@AndreMouche

This comment has been minimized.

Show comment
Hide comment
@AndreMouche

AndreMouche Sep 25, 2017

Member

/run-all-tests tidb=hanfei/ci

Member

AndreMouche commented Sep 25, 2017

/run-all-tests tidb=hanfei/ci

@AndreMouche AndreMouche merged commit 76bfe01 into master Sep 25, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tikv/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndreMouche AndreMouche deleted the shirly/dag_expression branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment