New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin: check if log is initialized when fatal #2263

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@BusyJay
Contributor

BusyJay commented Sep 7, 2017

In the past, we have to be very careful to choose whether to log or print when meet error in tikv-server because log system may not be initialized yet. The check can be done at runtime actually.

@BusyJay BusyJay requested review from siddontang, overvenus and disksing Sep 7, 2017

@siddontang

LGTM

@overvenus

LGTM

@BusyJay

This comment has been minimized.

Show comment
Hide comment
@BusyJay

BusyJay Sep 8, 2017

Contributor

/run-integration-test

Contributor

BusyJay commented Sep 8, 2017

/run-integration-test

@BusyJay BusyJay merged commit 71dd468 into master Sep 8, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tikv/build Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@BusyJay BusyJay deleted the busyjay/stderr-fatal branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment